Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-158927] Countdown Timer feedbacks incorporated #2955

Merged
merged 23 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/features/cdt/cdt.css
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@
display: flex;
}

html[dir="rtl"] .horizontal .timer-block {
margin-right: 10px;
rohitsahu marked this conversation as resolved.
Show resolved Hide resolved
margin-left: 0px;
flex-direction: row-reverse;
rohitsahu marked this conversation as resolved.
Show resolved Hide resolved
}

.horizontal .timer-block {
margin-left: 10px;
rohitsahu marked this conversation as resolved.
Show resolved Hide resolved
rohitsahu marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down Expand Up @@ -64,6 +70,10 @@
color: #1D1D1D;
}

html[dir="rtl"] .timer-unit-container {
flex-direction: row-reverse;
}

.timer-unit-container {
display: flex;
column-gap: 2px;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ runTests(async () => {
const el =
miniCompareChart.shadowRoot.querySelector(selector);
if (!el) return 0;
return parseFloat(window.getComputedStyle(el).height);
return parseInt(window.getComputedStyle(el).height);
rohitsahu marked this conversation as resolved.
Show resolved Hide resolved
})
.join(',');
return heights;
Expand All @@ -76,7 +76,7 @@ runTests(async () => {
.fill()
.map(
(_, i) =>
parseFloat(
parseInt(
rohitsahu marked this conversation as resolved.
Show resolved Hide resolved
window.getComputedStyle(
miniCompareChart.querySelector(
`.footer-row-cell:nth-child(${i + 1})`,
Expand Down
Loading