Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-158927] Countdown Timer feedbacks incorporated #2955

Merged
merged 23 commits into from
Sep 30, 2024
Merged

[MWPW-158927] Countdown Timer feedbacks incorporated #2955

Changes from 9 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f2bd706
Fix RTL issues with Countdown Timer
Sep 25, 2024
c7e4d1d
UT fix
Sep 25, 2024
e42a1e2
review comment
Sep 26, 2024
26a0fef
review comment
Sep 26, 2024
82e35d9
review comment
Sep 26, 2024
dcfa31f
font fixes
Sep 26, 2024
c193382
do not reverse
Sep 26, 2024
c781d19
Revert "UT fix"
Sep 26, 2024
cc8c772
Merge branch 'stage' into MWPW-158927
Sep 26, 2024
247905c
added CDT in notifications standard variant
Sep 26, 2024
7dae952
ends in vertical positioning fix
Sep 26, 2024
1f8ef7c
review comments
Sep 26, 2024
645180a
Merge branch 'stage' into MWPW-158927
Sep 26, 2024
8b3e921
UT added for cdt in notification
Sep 27, 2024
6ef6cc4
lint
Sep 27, 2024
10e9dba
css fixes
Sep 27, 2024
cb924d5
minor fix
Sep 27, 2024
56fb47b
lint
Sep 27, 2024
a1327a9
css
Sep 27, 2024
8da11ef
update timer for instant query param
Sep 27, 2024
398f172
narcis review feedback incorporated from PR https://github.com/adobec…
Sep 27, 2024
b6cdd32
minor refactoring
Sep 27, 2024
2b55639
fix CDT alignment in media and modal block
Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions libs/features/cdt/cdt.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}

.timer-label {
font-size: var(--type-body-s-size);
font-size: 16px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables should likely not be replaced, what was the intention here? Same comment for other variable replacements in this file.

At one point, we'll update all the variables to follow the Spectrum 2 guidelines, we want to make sure we avoid additional work at that point by having values already mapped to the ones in styles.css

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

font-weight: 700;
height: 27px;
}
Expand All @@ -31,12 +31,13 @@
margin: 0 2px 27px;
}

.timer-block {
display: flex;
.timer-separator {
margin: 0px 2px;
}

.horizontal .timer-block {
margin-left: 10px;
.timer-block {
display: flex;
margin-inline-start: 10px;
}

.timer-fragment {
Expand All @@ -49,7 +50,7 @@
padding: 0 9px;
width: 10px;
border-radius: 5px;
font-size: var(--type-body-m-size);
font-size: 18px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you going away from using variables? 🤔

font-weight: 700;
text-align: center;
}
Expand All @@ -64,6 +65,10 @@
color: #1D1D1D;
}

html[dir="rtl"] .timer-unit-container {
flex-direction: row-reverse;
}

.timer-unit-container {
display: flex;
column-gap: 2px;
Expand All @@ -72,7 +77,7 @@

.timer-unit-label {
width: 100%;
font-size: var(--type-body-xs-size);
font-size: 14px;
font-weight: 400;
text-align: start;
}
Expand Down
Loading