-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isSectionDividerRequired feature support to gnav #2958
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2958 +/- ##
=======================================
Coverage 96.30% 96.31%
=======================================
Files 242 242
Lines 54981 54982 +1
=======================================
+ Hits 52950 52954 +4
+ Misses 2031 2028 -3 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/navigation/navigation.js
Line 48 in 43df2e1
console.error('Global navigation Error: header and footer configurations are missing.'); |
Validation is done on the below url |
43df2e1
to
56180ce
Compare
Reminder to set the |
Closing this and putting the change in this PR |
Resolves: MWPW-159143
Test URLs:
Qa: https://adobecom.github.io/nav-consumer/navigation.html?navbranch=unav-divider&env=stage&showUnavSectionDivider=true