Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isSectionDividerRequired feature support to gnav #2958

Closed
wants to merge 3 commits into from

Conversation

bandana147
Copy link
Contributor

@bandana147 bandana147 commented Sep 25, 2024

  • Unav has a isSectionDividerRequired feature which gnav needs to support.
  • Global navigation component will take it in the config and pass it to unav config

Resolves: MWPW-159143

Test URLs:

Qa: https://adobecom.github.io/nav-consumer/navigation.html?navbranch=unav-divider&env=stage&showUnavSectionDivider=true

Copy link
Contributor

aem-code-sync bot commented Sep 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Sep 25, 2024
Copy link
Contributor

aem-code-sync bot commented Sep 25, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (05ebf1f) to head (56180ce).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2958   +/-   ##
=======================================
  Coverage   96.30%   96.31%           
=======================================
  Files         242      242           
  Lines       54981    54982    +1     
=======================================
+ Hits        52950    52954    +4     
+ Misses       2031     2028    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.error('Global navigation Error: header and footer configurations are missing.');

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Sep 26, 2024
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@bandana147
Copy link
Contributor Author

Closing this and putting the change in this PR

@bandana147 bandana147 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants