Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159197 Invoke onReady of standalone gnav when it is rendered #2962

Closed
wants to merge 1 commit into from

Conversation

sharmrj
Copy link
Contributor

@sharmrj sharmrj commented Sep 26, 2024

  • We now do await gnav.init() so that onReady is called only when gnav.init is finished executing

Resolves: MWPW-159197

Test URLs:

@sharmrj sharmrj changed the title https://jira.corp.adobe.com/browse/MWPW-159197 MWPW-159197 Invoke onReady of standalone gnav when it is rendered Sep 26, 2024
Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (501a373) to head (b436b7f).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2962   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         242      242           
  Lines       54873    54873           
=======================================
  Hits        52845    52845           
  Misses       2028     2028           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sharmrj
Copy link
Contributor Author

sharmrj commented Sep 26, 2024

In order to QA this PR I'll have to raise it from a branch off the main repo (as opposed to my fork)

@sharmrj sharmrj closed this Sep 26, 2024
@sharmrj sharmrj reopened this Sep 26, 2024
@sharmrj sharmrj closed this Sep 26, 2024
@sharmrj
Copy link
Contributor Author

sharmrj commented Sep 26, 2024

See #2963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant