MWPW-159197 Invoke onReady of standalone gnav when it is rendered #2962 #2963
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmrj
requested review from
salonijain3,
bandana147,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
mokimo
approved these changes
Sep 26, 2024
bandana147
approved these changes
Sep 26, 2024
Deva309
approved these changes
Sep 26, 2024
|
Validation done on the below url in slow network |
overmyheadandbody
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now do
await gnav.init()so thatonReadyis called only whengnav.initis finished executingResolves: MWPW-159197
Test URLs:
Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://await-gnav-init--milo--sharmrj.hlx.page/?martech=off
QA: https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=await-gnav-init