Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2965

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Release] Stage to Main #2965

wants to merge 6 commits into from

Conversation

rahulgupta999 and others added 4 commits September 26, 2024 14:40
…ch cards (#2946)

* Fix for MWPW-158004

* remove comments

* Adjust slots

* button fix

* add new body-lower slot for product card

* update deps

* Add unit test

* Add local unit test case for mas

* Add eventlistener to resize

* removed debug statements and comments

* UT failure

* Review comment

* ccov

* review comments
PEP now checks if the the useragent is one of a number of mobile devices.
* Jarvis stage for acom stage env

* Added test cases for asset URL verification

* Added test cases for asset URL verification

* Revert "Added test cases for asset URL verification"

This reverts commit 324e62c.

:wq#

* Clean up code by removing lint errors

* Revert "Clean up code by removing lint errors"

This reverts commit ae4dadc.

* Clean up code by removing lint errors

---------

Co-authored-by: Akansha Arora <>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 26, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (501a373) to head (4bc2230).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2965    +/-   ##
========================================
  Coverage   96.30%   96.31%            
========================================
  Files         242      242            
  Lines       54873    54987   +114     
========================================
+ Hits        52845    52959   +114     
  Misses       2028     2028            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…rallel to large menu. (#2942)

* Add support for custom links through link group in parallet to large menu

* Added UT for the changes

* lint fixes

* Bug fix mwpw-159018

* Bug fix mwpw-159018

* Bug fix mwpw-159018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.error('Global navigation Error: header and footer configurations are missing.');

…skip rows missing an action value (#2941)

* Add previewLog

* Add another log

* Add warn

* Remove unecessary log

* Update tests

* Update warn log

* Add code coverage for empty action

* Remove commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants