Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-144360 Prototype pollution tag selector #2967

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

Brandon32
Copy link
Contributor

  • Prevent prototype pollution detected by kodiak by using Object.create(null) and controlled keys.
  • Add lana message for consumer tag errors.

Resolves: MWPW-144360

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024

Page Scores Audits Google
📱 /tools/tag-selector?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /tools/tag-selector?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (5d8d656) to head (1f90361).
Report is 8 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff            @@
##            stage    #2967    +/-   ##
========================================
  Coverage   96.30%   96.30%            
========================================
  Files         242      242            
  Lines       54873    54999   +126     
========================================
+ Hits        52845    52967   +122     
- Misses       2028     2032     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants