MWPW-159236 Fix duplicate percent in donut chart tooltip #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganthecoder
requested review from
Brandon32 and
JasonHowellSlavin
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2968 +/- ##
==========================================
- Coverage 96.31% 96.30% -0.01%
==========================================
Files 242 242
Lines 54987 54987
==========================================
- Hits 52959 52954 -5
- Misses 2028 2033 +5 ☔ View full report in Codecov by Sentry. |
Brandon32
approved these changes
Sep 26, 2024
meganthecoder
added
run-nala
JasonHowellSlavin
approved these changes
Sep 26, 2024
|
Reminder to set the |
rohitsahu
pushed a commit
to rohitsahu/milo
that referenced
this pull request
Oct 1, 2024
* stage: MWPW-158886: update the way we send arbitrary fields to caas (adobecom#2977) MWPW-159028: MAS more technical documents + refactored aem related code (adobecom#2952) MWPW-158776 Fix video CLS (adobecom#2915) MWPW-159197 Invoke onReady of standalone gnav when it is rendered adobecom#2962 (adobecom#2963) MWPW-159157: Update modal to account for new image size (adobecom#2975) Reverts MWPW-157555: Causing prices and CTAs to fail in Safari (adobecom#2987) [MWPW-159287 : NALA] Enhance Nala Run Command to Support Feature Branches with with an owner other than 'adobecom' (adobecom#2978) [MWPW-158927] Countdown Timer feedbacks incorporated (adobecom#2955) [MWPW-159265] Callout text in RTL not properly aligned (adobecom#2974) Add support for Jarvis through Unav and make appID of notifications configurable (adobecom#2969) MWPW-159236 Fix duplicate percent in donut chart tooltip (adobecom#2968) MWPW-144360 Prototype pollution tag selector (adobecom#2967) [MWPW-153616] Update 404 links in region selector (adobecom#2956) MWPW-157555: Remove useless logic and putting import commerce.js top. (adobecom#2906) # Conflicts: # libs/deps/mas/mas.js # libs/deps/mas/merch-card.js # libs/deps/mas/plans-modal.js # libs/features/mas/web-components/src/global.css.js
jenssingler
pushed a commit
to jenssingler/milo
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-159236
Test URLs:
Milo:
Bacom: