Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155723 - Adds group metadata to ensure dyanmic nav continuity #3124

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from

Conversation

JasonHowellSlavin
Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin commented Oct 31, 2024

@JasonHowellSlavin JasonHowellSlavin changed the base branch from dynamic-nav-status-button to stage October 31, 2024 17:52
@JasonHowellSlavin JasonHowellSlavin added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

aem-code-sync bot commented Nov 7, 2024

Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.38%. Comparing base (6f4d98c) to head (c49337e).

Files with missing lines Patch % Lines
.../features/dynamic-navigation/dynamic-navigation.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3124   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files         245      245           
  Lines       56716    56734   +18     
=======================================
+ Hits        54661    54683   +22     
+ Misses       2055     2051    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires E2E testing by a reviewer run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants