Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160510 - Expand icon tooltip functionality #3173

Closed
wants to merge 6 commits into from

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Nov 11, 2024

Extends the current milo tooltip functionality to be able to use it on other icons besides the information icon. Tooltips will now also be considered in placeholder decoration, so you can use placeholders as tooltip content.

Authoring
To author icon tooltips the icon should append the desired position/text separated by | and then be italicized.
example: :lock: | top | Desired tooltip text

Backwards compatibility
This is supporting legacy tooltip authoring by updating all :tooltip: icons to use the :info-outline: icon. (Legacy implementation uses same position/text authoring)

Resolves: MWPW-160510

Test URLs:

@Sartxi Sartxi added new-feature New block or other feature needs-verification PR requires E2E testing by a reviewer labels Nov 11, 2024
Copy link
Contributor

aem-code-sync bot commented Nov 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 11, 2024

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (df454db) to head (d470e7e).
Report is 11 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3173      +/-   ##
==========================================
- Coverage   96.38%   96.37%   -0.01%     
==========================================
  Files         245      245              
  Lines       56651    56651              
==========================================
- Hits        54601    54596       -5     
- Misses       2050     2055       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160510-tooltip November 11, 2024 19:52 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160510-tooltip November 11, 2024 19:56 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160510-tooltip November 11, 2024 20:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PR should not be merged yet needs-verification PR requires E2E testing by a reviewer new-feature New block or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant