[MWPW-145672] Change link color only on hover #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3186 +/- ##
==========================================
+ Coverage 96.37% 98.83% +2.46%
==========================================
Files 245 70 -175
Lines 56598 8571 -48027
==========================================
- Hits 54545 8471 -46074
+ Misses 2053 100 -1953 ☔ View full report in Codecov by Sentry. |
robert-bogos
approved these changes
Nov 13, 2024
mokimo
approved these changes
Nov 13, 2024
|
Testing for this fix will be done on stage or both this PR and #3166 will be reverted. |
mokimo
added a commit
that referenced
this pull request
Nov 13, 2024
* [MWPW-160011] - GNAV light mode color changes (#3019) * Color changes * Promo background color fix * Add text and subtext font color changes in megamenu * cross cloud menu background color changes * Fix reveiew comments * colors hexcode formatted as lowercase for css variables * Bug fix MWPW-161889 * MWPW-161590, 161606, 161871, 161987 [MEP] Update placeholders before updating href (#3142) * MWPW-161590 [MEP] Update placeholders before updating href * unit test updates * MWPW-161871 [MEP] useblockcode action fails if page is on milo site (#3161) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * update unit tests * MWPW-149504 [MILO][MEP] Move entitlements object to the same JSON file used by the library (#3047) * create mepxlg branch * update library * require full hostname match * update reference for unit test * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064) * add federated link function to registerInBlockActions * add to unit test * add unit test coverage * initial commit * Fix useblock code issue --------- Co-authored-by: vgoodric <vgoodric@adobe.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * MWPW-161606 [MEP] Modify within modals with MEP (#3171) initial commit publish Co-authored-by: viloria <viloria@adobe.com> * add conditionals --------- Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com> * [MWPW-161782] - Added logo changes for older GNAV experience (#3162) * Added logo changes for older GNAV experience * Lint Fix * Logo alighned to left for older GNAV * [MWPW-161563] CDT Overlap in Global and APAC Promotion file (#3168) * Use schedule as source for CDT * seperate start and end * Added unit tests * [MWPW-157451] [Accessibility] Merch cards | Focus is lost on comparing plans section (#3103) * remive tabindex=0 as the attributes from merchcard div * fresh commit with same changes as commit 1 after resolving the merge conflict * Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added. * Revert "Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added." This reverts commit 610807a. * run build in mas * run build --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com> * MWPW-159381: Replaces CSS 'body *' with '.consonant-Wrapper *' (#3152) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <> * Replaces CSS 'body *' with '.consonant-Wrapper *' --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> * [MWPW-160948] Remove blockquote default spacing (#3159) * [MWPW-161098] Environment-aware links support for CaaS (#3165) * relative urls caas support * added unit tests * [MWPW-162059] - Fix for vertical alignment of logo on AH (#3180) Fix for verticle alignment of logo * Global links underlined by default (#3166) * a links underline, a.quite added * added styles to omit header/footer * added default link styles for headlines and lockup area * minor :hover style alignment on cards-horiz, marquee-anchors, brick * removed dubs underline on links * removed styles overrides to support double in horiz-card, marquee-anch, brick * [MWPW-145672] Remove Gnav global link styles * [MWPW-161624] Link farm double underline on focus * Ensure sub text in anchors is underlined correctly * Ensure sub text in anchors is underlined correctly --------- Co-authored-by: thi64146 <thi64146@adobe.com> * Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3183) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#2986)" This reverts commit f379815. Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * [MWPW-145672] Change link color only on hover (#3186) --------- Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Rahul Gupta <rahulgupta999@gmail.com> Co-authored-by: rohitsahu <sahurohit9@gmail.com> Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Narcis Radu <github@narcisradu.ro>
mokimo
added a commit
that referenced
this pull request
Nov 13, 2024
* [MWPW-160011] - GNAV light mode color changes (#3019) * Color changes * Promo background color fix * Add text and subtext font color changes in megamenu * cross cloud menu background color changes * Fix reveiew comments * colors hexcode formatted as lowercase for css variables * Bug fix MWPW-161889 * MWPW-161590, 161606, 161871, 161987 [MEP] Update placeholders before updating href (#3142) * MWPW-161590 [MEP] Update placeholders before updating href * unit test updates * MWPW-161871 [MEP] useblockcode action fails if page is on milo site (#3161) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * update unit tests * MWPW-149504 [MILO][MEP] Move entitlements object to the same JSON file used by the library (#3047) * create mepxlg branch * update library * require full hostname match * update reference for unit test * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064) * add federated link function to registerInBlockActions * add to unit test * add unit test coverage * initial commit * Fix useblock code issue --------- Co-authored-by: vgoodric <vgoodric@adobe.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * MWPW-161606 [MEP] Modify within modals with MEP (#3171) initial commit publish Co-authored-by: viloria <viloria@adobe.com> * add conditionals --------- Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com> * [MWPW-161782] - Added logo changes for older GNAV experience (#3162) * Added logo changes for older GNAV experience * Lint Fix * Logo alighned to left for older GNAV * [MWPW-161563] CDT Overlap in Global and APAC Promotion file (#3168) * Use schedule as source for CDT * seperate start and end * Added unit tests * [MWPW-157451] [Accessibility] Merch cards | Focus is lost on comparing plans section (#3103) * remive tabindex=0 as the attributes from merchcard div * fresh commit with same changes as commit 1 after resolving the merge conflict * Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added. * Revert "Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added." This reverts commit 610807a. * run build in mas * run build --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com> * MWPW-159381: Replaces CSS 'body *' with '.consonant-Wrapper *' (#3152) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <> * Replaces CSS 'body *' with '.consonant-Wrapper *' --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> * [MWPW-160948] Remove blockquote default spacing (#3159) * [MWPW-161098] Environment-aware links support for CaaS (#3165) * relative urls caas support * added unit tests * [MWPW-162059] - Fix for vertical alignment of logo on AH (#3180) Fix for verticle alignment of logo * Global links underlined by default (#3166) * a links underline, a.quite added * added styles to omit header/footer * added default link styles for headlines and lockup area * minor :hover style alignment on cards-horiz, marquee-anchors, brick * removed dubs underline on links * removed styles overrides to support double in horiz-card, marquee-anch, brick * [MWPW-145672] Remove Gnav global link styles * [MWPW-161624] Link farm double underline on focus * Ensure sub text in anchors is underlined correctly * Ensure sub text in anchors is underlined correctly --------- Co-authored-by: thi64146 <thi64146@adobe.com> * Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3183) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#2986)" This reverts commit f379815. Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * [MWPW-145672] Change link color only on hover (#3186) --------- Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Rahul Gupta <rahulgupta999@gmail.com> Co-authored-by: rohitsahu <sahurohit9@gmail.com> Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Narcis Radu <github@narcisradu.ro>
mokimo
added a commit
that referenced
this pull request
Nov 13, 2024
commit ee9d4a1 Merge: 668448b 9b05053 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Oct 3 17:13:53 2024 +0000 [Release] Stage to Main (#2990) commit 668448b Merge: 23e81de d9ab9a2 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Oct 1 08:04:45 2024 +0000 [Release] Stage to Main (#2980) commit 23e81de Merge: 4e0704d 4bc2230 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Sep 30 08:10:09 2024 +0000 [Release] Stage to Main (#2965) commit 4e0704d Merge: 3d3a739 501a373 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Sep 26 14:40:26 2024 +0000 [Release] Stage to Main (#2951) commit 3d3a739 Merge: 7c2d611 5ddeb73 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Sep 25 08:32:27 2024 +0000 [Release] Stage to Main (#2943) commit 7c2d611 Merge: 132d69f b600045 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Sep 24 08:47:25 2024 +0000 [Release] Stage to Main (#2910) commit 132d69f Merge: fb228f1 54c3cc0 Author: Blaine Gunn <Blainegunn@gmail.com> Date: Wed Sep 18 15:54:02 2024 -0600 [Release] Stage to Main (#2898) commit fb228f1 Author: Okan Sahin <39759830+mokimo@users.noreply.github.com> Date: Wed Sep 18 12:37:01 2024 +0200 Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. commit cc08e6e Merge: d4cb64b 9323f28 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Sep 18 09:16:27 2024 +0000 [Release] Stage to Main (#2893) commit d4cb64b Merge: b60741a 840e037 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Sep 17 09:15:15 2024 +0000 [Release] Stage to Main (#2879) commit b60741a Merge: a35fcb3 6fa9558 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Sep 16 08:52:26 2024 +0000 [Release] Stage to Main (#2874) commit a35fcb3 Merge: c7a5d14 3679fd0 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Sep 12 17:00:11 2024 +0000 [Release] Stage to Main (#2868) commit c7a5d14 Merge: 28a75e5 3fd877c Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Sep 11 09:15:46 2024 +0000 [Release] Stage to Main (#2859) commit 28a75e5 Merge: c8d526f 2802011 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Sep 10 09:16:08 2024 +0000 [Release] Stage to Main (#2852) commit c8d526f Merge: 95fb526 99a0fd7 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Sep 9 16:08:50 2024 +0000 [Release] Stage to Main (#2842) commit 95fb526 Merge: 91afbee 264c998 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Sep 5 16:45:17 2024 +0000 [Release] Stage to Main (#2821) commit 91afbee Merge: eeddca4 7216452 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Sep 3 18:07:49 2024 +0000 [Release] Stage to Main (#2811) commit eeddca4 Merge: c06c15d 6012fcb Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Sep 2 08:16:45 2024 +0000 [Release] Stage to Main (#2775) commit c06c15d Merge: 7dbef3a 2abe70f Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Aug 21 18:20:05 2024 +0000 [Release] Stage to Main (#2766) commit 7dbef3a Merge: 53f37de dad8c45 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Aug 20 18:10:09 2024 +0000 [Release] Stage to Main (#2756) commit 53f37de Merge: baef0d5 f92f07c Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Aug 19 08:12:17 2024 +0000 [Release] Stage to Main (#2742) commit baef0d5 Merge: 0b80fa1 302e9be Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Aug 14 08:19:13 2024 +0000 [Release] Stage to Main (#2734) commit 0b80fa1 Merge: 3abbe4d 60cb005 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Aug 13 16:08:05 2024 +0000 [Release] Stage to Main (#2722) commit 3abbe4d Merge: 833abd4 7b9c7cf Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Aug 12 09:15:18 2024 +0000 [Release] Stage to Main (#2716) commit 833abd4 Merge: 5401829 ccb9704 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Aug 8 20:04:32 2024 +0000 [Release] Stage to Main (#2701) commit 5401829 Merge: 498b7c8 6418e29 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Aug 7 09:03:07 2024 +0000 [Release] Stage to Main (#2697) commit 498b7c8 Merge: 8f6bc8f 94b5b91 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Aug 6 16:51:41 2024 +0000 [Release] Stage to Main (#2688) commit 8f6bc8f Merge: c3371ce 071a858 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Aug 5 09:14:21 2024 +0000 [Release] Stage to Main (#2666) commit c3371ce Merge: 0073337 8232146 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jul 31 08:59:04 2024 +0000 [Release] Stage to Main (#2648) commit 0073337 Merge: 5028ef5 c00c777 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jul 30 08:13:26 2024 +0000 [Release] Stage to Main (#2641) commit 5028ef5 Merge: f551e5b add9745 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jul 29 08:22:11 2024 +0000 [Release] Stage to Main (#2629) commit f551e5b Merge: e89908c c0395ae Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Jul 25 09:15:40 2024 +0000 [Release] Stage to Main (#2617) commit e89908c Merge: 3365940 3afac8d Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jul 24 08:06:01 2024 +0000 [Release] Stage to Main (#2609) commit 3365940 Merge: 61f8c81 58a1fdf Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jul 23 09:14:47 2024 +0000 [Release] Stage to Main (#2602) commit 61f8c81 Merge: 4e99424 31c21e8 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jul 22 15:11:42 2024 +0000 [Release] Stage to Main (#2592) commit 4e99424 Merge: 04e211c 0aa18e7 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Jul 18 17:07:37 2024 +0000 [Release] Stage to Main (#2580) commit 04e211c Merge: bc210e6 ba623c3 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jul 17 10:12:25 2024 +0000 [Release] Stage to Main (#2571) commit bc210e6 Merge: 830f7e1 fc03376 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jul 16 09:15:42 2024 +0000 [Release] Stage to Main (#2568) commit 830f7e1 Merge: 88577c7 c896518 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jul 15 09:15:20 2024 +0000 [Release] Stage to Main (#2556) commit 88577c7 Merge: 862fdab a77e493 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jul 10 17:58:39 2024 +0000 [Release] Stage to Main (#2540) commit 862fdab Merge: 2217784 f5b5121 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jul 8 09:15:20 2024 +0000 [Release] Stage to Main (#2528) commit 2217784 Merge: 32f61f0 5e2dd4c Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Jun 27 09:14:10 2024 +0000 [Release] Stage to Main (#2520) commit 32f61f0 Merge: 03578fb 75d922e Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jun 26 09:15:54 2024 +0000 [Release] Stage to Main (#2515) commit 03578fb Merge: 47aaef0 1a8acc6 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jun 25 09:14:17 2024 +0000 [Release] Stage to Main (#2503) commit 47aaef0 Merge: f6fc4bf 5ad4b21 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jun 24 09:07:58 2024 +0000 [Release] Stage to Main (#2495) commit f6fc4bf Merge: 02bf1a6 75fe20d Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Jun 20 09:14:59 2024 +0000 [Release] Stage to Main (#2489) commit 02bf1a6 Merge: ddbdf7a 0428594 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jun 19 14:23:57 2024 +0000 [Release] Stage to Main (#2482) commit ddbdf7a Merge: ead382f 16c64e4 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jun 18 10:37:30 2024 +0000 [Release] Stage to Main (#2479) commit ead382f Merge: 931fa67 0cdd84a Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jun 17 09:14:39 2024 +0000 [Release] Stage to Main (#2472) commit 931fa67 Merge: 2350bd0 3d61c97 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Jun 13 16:08:16 2024 +0000 [Release] Stage to Main (#2470) commit 2350bd0 Merge: e8300af 5a932b9 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jun 12 11:40:48 2024 +0000 [Release] Stage to Main (#2462) commit e8300af Merge: 81d0085 f5e66e0 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jun 11 19:11:02 2024 +0000 [Release] Stage to Main (#2447) commit 81d0085 Merge: e5bff30 ca8ba03 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jun 10 09:15:44 2024 +0000 [Release] Stage to Main (#2432) commit e5bff30 Merge: b07f1a5 95a6593 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Thu Jun 6 09:15:01 2024 +0000 [Release] Stage to Main (#2423) commit b07f1a5 Merge: d9af238 fe0adb4 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Wed Jun 5 09:02:44 2024 +0000 [Release] Stage to Main (#2414) commit d9af238 Merge: be90c7d a60b132 Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Tue Jun 4 10:34:02 2024 +0000 [Release] Stage to Main (#2409) commit be90c7d Merge: b8b1871 0c0a36b Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Date: Mon Jun 3 15:20:01 2024 +0000 [Release] Stage to Main (#2359) [Release] Stage to Main (#3181) * [MWPW-160011] - GNAV light mode color changes (#3019) * Color changes * Promo background color fix * Add text and subtext font color changes in megamenu * cross cloud menu background color changes * Fix reveiew comments * colors hexcode formatted as lowercase for css variables * Bug fix MWPW-161889 * MWPW-161590, 161606, 161871, 161987 [MEP] Update placeholders before updating href (#3142) * MWPW-161590 [MEP] Update placeholders before updating href * unit test updates * MWPW-161871 [MEP] useblockcode action fails if page is on milo site (#3161) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * update unit tests * MWPW-149504 [MILO][MEP] Move entitlements object to the same JSON file used by the library (#3047) * create mepxlg branch * update library * require full hostname match * update reference for unit test * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064) * add federated link function to registerInBlockActions * add to unit test * add unit test coverage * initial commit * Fix useblock code issue --------- Co-authored-by: vgoodric <vgoodric@adobe.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * MWPW-161606 [MEP] Modify within modals with MEP (#3171) initial commit publish Co-authored-by: viloria <viloria@adobe.com> * add conditionals --------- Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com> * [MWPW-161782] - Added logo changes for older GNAV experience (#3162) * Added logo changes for older GNAV experience * Lint Fix * Logo alighned to left for older GNAV * [MWPW-161563] CDT Overlap in Global and APAC Promotion file (#3168) * Use schedule as source for CDT * seperate start and end * Added unit tests * [MWPW-157451] [Accessibility] Merch cards | Focus is lost on comparing plans section (#3103) * remive tabindex=0 as the attributes from merchcard div * fresh commit with same changes as commit 1 after resolving the merge conflict * Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added. * Revert "Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added." This reverts commit 610807a. * run build in mas * run build --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com> * MWPW-159381: Replaces CSS 'body *' with '.consonant-Wrapper *' (#3152) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <> * Replaces CSS 'body *' with '.consonant-Wrapper *' --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> * [MWPW-160948] Remove blockquote default spacing (#3159) * [MWPW-161098] Environment-aware links support for CaaS (#3165) * relative urls caas support * added unit tests * [MWPW-162059] - Fix for vertical alignment of logo on AH (#3180) Fix for verticle alignment of logo * Global links underlined by default (#3166) * a links underline, a.quite added * added styles to omit header/footer * added default link styles for headlines and lockup area * minor :hover style alignment on cards-horiz, marquee-anchors, brick * removed dubs underline on links * removed styles overrides to support double in horiz-card, marquee-anch, brick * [MWPW-145672] Remove Gnav global link styles * [MWPW-161624] Link farm double underline on focus * Ensure sub text in anchors is underlined correctly * Ensure sub text in anchors is underlined correctly --------- Co-authored-by: thi64146 <thi64146@adobe.com> * Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3183) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#2986)" This reverts commit f379815. Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * [MWPW-145672] Change link color only on hover (#3186) --------- Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: Rahul Gupta <rahulgupta999@gmail.com> Co-authored-by: rohitsahu <sahurohit9@gmail.com> Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Akansha Arora <akanshaarora090@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Narcis Radu <github@narcisradu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3166 introduced an issue where the blue color is applied to links on focus and active. This change will remove the states and will only keep hover.
Resolves: MWPW-145672
Test URLs:
Additional test URLs