Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162305: [Black Friday] CTA not visible on CRM due to sticky banner #3188

Closed

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Nov 13, 2024

Increasing z-index for .commerce-frame modals and modal curtains to overlap the promo banner.
The issue with modal URLs is fixed in this related CC PR: adobecom/cc#450 .

Resolves: MWPW-162305

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 13, 2024

Page Scores Audits Google
📱 /?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (343ba6e) to head (6e5509a).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3188      +/-   ##
==========================================
+ Coverage   96.37%   98.83%   +2.45%     
==========================================
  Files         245       70     -175     
  Lines       56598     8573   -48025     
==========================================
- Hits        54548     8473   -46075     
+ Misses       2050      100    -1950     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirafedas mirafedas closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant