Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159201: Create custom marquee for Catalog page to improve performance #3190

Closed

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Nov 13, 2024

Adding the catalog marquee block to meet specific design requirements and improve catalog page performance by eliminating fragments and stripping off unnecessary JavaScript and CSS associated with unused marquee features.

Resolves: MWPW-159201

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 13, 2024

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (5d2107e) to head (56436b2).
Report is 4 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3190      +/-   ##
==========================================
+ Coverage   96.38%   98.83%   +2.44%     
==========================================
  Files         245       70     -175     
  Lines       56686     8573   -48113     
==========================================
- Hits        54636     8473   -46163     
+ Misses       2050      100    -1950     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mokimo
Copy link
Contributor

mokimo commented Nov 13, 2024

What's the gains you are seeing with this? Just as an FYI, with this any updates to the "normal" marquee, won't be available for the catalog page. Page specific blocks sound like a maintenance anti-pattern 🤔

@yesil
Copy link
Contributor

yesil commented Nov 13, 2024

@mirafedas ideally this should go to CC and not Milo if it is specific to a CC page.

@mirafedas
Copy link
Contributor Author

@yesil will move this to CC, thus closing this PR

@mirafedas mirafedas closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants