Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-141870: Update seotech-video-url API endpoint #3194

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

hparra
Copy link
Contributor

@hparra hparra commented Nov 14, 2024

Update seotech-video-url feature to use new version of API endpoint behind adobe.com.

Resolves: MWPW-141870

Context

I update the implementation of the seotech-video-url feature to use a new version of seotech API endpoint which allows for proper caching and sits behind adobe.com. We now parse video urls locally first and call the endpoint if url is supported. There are no visible changes to the user.

I also update the seotech README for future developers.

Testing

Unit

I updated all unit tests and added extensive tests for regex.

E2E

Use the following snippet in dev console to confirm added VideoObject JSON-LD on each non-error page:

Array.from(document.querySelectorAll('script[type="application/ld+json"]')).map((el) => JSON.parse(el.innerText))

Before URLs:

After URLs:

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (931e97a) to head (7615cfa).
Report is 12 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3194      +/-   ##
==========================================
+ Coverage   96.37%   96.38%   +0.01%     
==========================================
  Files         245      245              
  Lines       56598    56716     +118     
==========================================
+ Hits        54545    54666     +121     
+ Misses       2053     2050       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hparra hparra changed the title MWPW-141870: MWPW-141870: Update seotech-video-url API endpoint Nov 14, 2024
@hparra hparra marked this pull request as ready for review November 14, 2024 04:12
libs/features/seotech/seotech.js Show resolved Hide resolved
libs/features/seotech/seotech.js Outdated Show resolved Hide resolved
libs/features/seotech/seotech.js Outdated Show resolved Hide resolved
@milo-pr-merge milo-pr-merge bot merged commit 6f4d98c into adobecom:stage Nov 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants