Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161587 - Support typed query indexes #3205

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from
Open

Conversation

auniverseaway
Copy link
Member

@auniverseaway auniverseaway commented Nov 15, 2024

  • Supports type-safe query indexes

Resolves: MWPW-161587

Milo URLs:

Test URLs:

How to test:
Note: there are unrelated errors that can be reproduced on the existing site. Something related to status.js.

  1. Navigate to the test before page.
    • Note that there is not a list of cards under the featured article (top area).
    • Note the errors in the JS console regarding article-helpers.js
  2. Navigate to the test after page.
    • Note the cards that now display below the featured article (top area)
    • Note the lack of errors in the JS console regarding article-helpers.js

* Supports type-safe query indexes

Resolves: MWPW-161587
Copy link
Contributor

aem-code-sync bot commented Nov 15, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (6f4d98c) to head (de69603).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3205   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files         245      245           
  Lines       56716    56722    +6     
=======================================
+ Hits        54661    54672   +11     
+ Misses       2055     2050    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Nov 15, 2024

Page Scores Audits Google
📱 /blog/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /blog/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant