Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.10 and Kotlin-DSL #56

Merged
merged 17 commits into from
Aug 27, 2024

Conversation

sdavids
Copy link
Contributor

@sdavids sdavids commented Aug 24, 2024

  • updated all dependencies
  • migrated build.gradle to Kotlin-DSL
  • migrated settings.gradle to Kotlin-DSL
  • ensure reproducible build
  • minor fix to shell script

I suggest you review commit-by-commit …

@sdavids sdavids force-pushed the users/sdavids/feat/issue-55 branch 2 times, most recently from 78efc72 to d58f7cb Compare August 24, 2024 16:06
https://www.shellcheck.net/wiki/SC2086

Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
Signed-off-by: Sebastian Davids <sdavids@gmx.de>
@sdavids sdavids force-pushed the users/sdavids/feat/issue-55 branch from d58f7cb to 31bf3c4 Compare August 24, 2024 20:39
@sdavids sdavids force-pushed the users/sdavids/feat/issue-55 branch from 31bf3c4 to 68a96e5 Compare August 24, 2024 20:43
@sdavids
Copy link
Contributor Author

sdavids commented Aug 24, 2024

I have not included the gradle-graal plugin due to it not being updated in 2 years.

It has not kept up with the changes in Gradle 8 nor the ones for the upcoming Gradle 9.

Also, there are several important open issues:

I really don't know why this plugin is so strict about the graalvm and jdk version, every single time Graal upgrades the plugin stops working.


The plugin seems to be abondoned.

@sdavids sdavids marked this pull request as ready for review August 24, 2024 21:03
@sdavids
Copy link
Contributor Author

sdavids commented Aug 24, 2024

@adoble adoble merged commit 90429ee into adoble:main Aug 27, 2024
1 check passed
@adoble
Copy link
Owner

adoble commented Aug 27, 2024

I agree with your appraisal of GraalVM and are happy to leave it out (I'll mention in the CHANGELOG that this is the case).

If anybody has a need for this, then please raise an issue.

@sdavids sdavids deleted the users/sdavids/feat/issue-55 branch August 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants