Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CA Certs #3573

Closed
wants to merge 3 commits into from
Closed

Update CA Certs #3573

wants to merge 3 commits into from

Conversation

eclipse-temurin-bot
Copy link
Contributor

See details in the Meta Bug linked from the Root Cert Inclusions into Mozilla Product Releases section of https://wiki.mozilla.org/NSS:Release_Versions

@github-actions GitHub Actions
Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@karianna
Copy link
Contributor

Seems odd that there is a conflict...

@AdamBrousseau AdamBrousseau mentioned this pull request Dec 13, 2023
Merged
AdamBrousseau added a commit to AdamBrousseau/openjdk-build that referenced this pull request Dec 15, 2023
@AdamBrousseau
Update expected CA cert count
f91a1b2 
Issue infra 8728
Related adoptium#3573

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau mentioned this pull request Dec 15, 2023
Merged
karianna
karianna requested changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict, why?

@Haroon-Khel Haroon-Khel requested a review from karianna January 9, 2024 11:55
@andrew-m-leonard
Copy link
Contributor

merge conflict, why?

Looks like the branch is 57 commits behind "master" , was it possibly created from a local "master" branch?

@andrew-m-leonard
Copy link
Contributor

Is this a "bot" created branch? looks like it's a diverged branch: https://github.com/adoptium/temurin-build/tree/create-or-update-pull-request-action

@karianna
Copy link
Contributor

karianna commented Jan 9, 2024

Is this a "bot" created branch? looks like it's a diverged branch: https://github.com/adoptium/temurin-build/tree/create-or-update-pull-request-action

It does appear to be bot generated but I'm not sure who our internal expert on this area is!

@gdams
Copy link
Member

gdams commented Jan 10, 2024

I'm not sure who our internal expert on this area is!

I wrote the bot, I'll delete this branch and re-run the workflow

@gdams gdams closed this Jan 10, 2024
@gdams gdams deleted the create-or-update-pull-request-action branch January 10, 2024 09:22
@gdams
Copy link
Member

gdams commented Jan 10, 2024

There is a new PR here: #3605

One thing the bot doesn't do right now is update the total number of certs which causes the smoke test to fail. We could do with extending the functionality if this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@karianna karianna Awaiting requested review from karianna

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eclipse-temurin-bot @karianna @andrew-m-leonard @gdams @tellison