Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CA Certs #3605

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update CA Certs #3605

merged 2 commits into from
Jan 10, 2024

Conversation

eclipse-temurin-bot
Copy link
Contributor

See details in the Meta Bug linked from the Root Cert Inclusions into Mozilla Product Releases section of https://wiki.mozilla.org/NSS:Release_Versions

Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires cert check update:

Failed to match CA certs number. expected [143] but found [146]

@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Jan 10, 2024

Smoke tests failing on windows machines. Do we know if this is related to the certs update?

    [javac] D:\a\temurin-build\temurin-build\aqa-tests\TKG\src\org\testKitGen\TestDivider.java:168: error: cannot find symbol
    [javac] 					JSONObject testData = (JSONObject) testList.get(i);
    [javac] 					                       ^
    [javac]   symbol:   class JSONObject
    [javac]   location: class TestDivider
    [javac] D:\a\temurin-build\temurin-build\aqa-tests\TKG\src\org\testKitGen\TestDivider.java:208: error: cannot find symbol
    [javac] 				} catch (IOException|ParseException e) {
    [javac] 				                     ^
    [javac]   symbol:   class ParseException
    [javac]   location: class TestDivider
    [javac] D:\a\temurin-build\temurin-build\aqa-tests\TKG\src\org\testKitGen\TestDivider.java:242: error: cannot find symbol
    [javac] 		} catch (IOException | ParseException e) {
    [javac] 		                       ^
    [javac]   symbol:   class ParseException
    [javac]   location: class TestDivider
    [javac] 17 errors

BUILD FAILED
D:\a\temurin-build\temurin-build\aqa-tests\TKG\scripts\build_tools.xml:58: The following error occurred while executing this line:
D:\a\temurin-build\temurin-build\aqa-tests\TKG\scripts\build_tools.xml:37: Compile failed; see the compiler error output for details.

Total time: 1 second
1
make: *** [makefile:107: compileTools] Error 1

Output doesnt really tell much

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo
Copy link
Contributor

Smoke tests failing on windows machines. Do we know if this is related to the certs update?

No, it's related with LIB_DIR

@sophia-guo sophia-guo merged commit 928b569 into master Jan 10, 2024
22 of 26 checks passed
@gdams gdams deleted the create-or-update-pull-request-action branch January 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants