Change expire_in to expire_at and support new format #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thostetler
commented
May 22, 2024
thostetler
commented
- Now supports new expiration time format (seconds since epoch)
- Updates logging for tests
logging during testing was difficult since objects were getting skipped. This may be fixed in a current version of puppeteer, but for now this fix works to output the value
This was looking at the wrong property on the incoming bootstrap response
thostetler
force-pushed
the
gateway-tweaks
branch
from
bf3403a
to
568863a
Compare
thostetler
force-pushed
the
gateway-tweaks
branch
from
568863a
to
f4a15e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.