Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed the putcode to always be string and added a test #47

Merged
merged 2 commits into from
Aug 2, 2023
Merged

changed the putcode to always be string and added a test #47

merged 2 commits into from
Aug 2, 2023

Conversation

femalves
Copy link
Contributor

No description provided.

@femalves femalves requested a review from tjacovich July 27, 2023 15:47
tjacovich
tjacovich requested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick tweak of the test to keep it consistent with the others and I think it's good to go.

orcid_service/tests/test_service.py Outdated Show resolved Hide resolved
@tjacovich tjacovich linked an issue Jul 28, 2023 that may be closed by this pull request
Bug: putcode is sometimes stored as a number, sometimes a string #46
Closed
@femalves femalves requested a review from tjacovich July 28, 2023 16:19
tjacovich
tjacovich approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@femalves femalves merged commit bbb7dda into master Aug 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjacovich tjacovich tjacovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: putcode is sometimes stored as a number, sometimes a string
2 participants
@femalves @tjacovich