Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract C-contiguous arrays by default from fields #856

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Sep 23, 2024

closes #857.

Example

>>> import felupe as fem
>>> 
>>> mesh = fem.Cube(n=11).triangulate().add_midpoints_volumes(cell_type="tetra")
>>> region = fem.RegionTetraMINI(mesh)
>>> field = fem.FieldsMixed(region, n=3)
>>> 
>>> field.extract()[0].flags
  C_CONTIGUOUS : True
  F_CONTIGUOUS : False
  OWNDATA : True
  WRITEABLE : True
  ALIGNED : True
  WRITEBACKIFCOPY : False

@adtzlr adtzlr added the enhancement New feature or request label Sep 23, 2024
@adtzlr adtzlr self-assigned this Sep 23, 2024
@adtzlr adtzlr changed the title Field extract contiguous Extract C-contiguous arrays by default from fields Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (2961ad1) to head (78dee44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         149      149           
  Lines        5732     5735    +3     
=======================================
+ Hits         5592     5595    +3     
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 9a83fdd into main Sep 23, 2024
8 checks passed
@adtzlr adtzlr deleted the field-extract-contiguous branch September 23, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracted arrays of fields are not C-contiguous
1 participant