Merge pull request #3313 from mikiher/author-image-path

Update AuthorController to handle invalid image paths and log a warning
advplyr · Aug 21, 2024 · 1c0d6e9 · 1c0d6e9
2 parents 7d711da + 20a3657
commit 1c0d6e9
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/server/controllers/AuthorController.js b/server/controllers/AuthorController.js
@@ -368,12 +368,12 @@ class AuthorController {
       author
     } = req
 
-    if (raw) {
-      // any value
-      if (!author.imagePath || !(await fs.pathExists(author.imagePath))) {
-        return res.sendStatus(404)
-      }
+    if (!author.imagePath || !(await fs.pathExists(author.imagePath))) {
+      Logger.warn(`[AuthorController] Author "${author.name}" has invalid imagePath: ${author.imagePath}`)
+      return res.sendStatus(404)
+    }
 
+    if (raw) {
       return res.sendFile(author.imagePath)
     }