-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation strings added #3304
Conversation
Got some more strings translated. I also cleaned up a few similar strings that were already in the translation files. This PR should be good to merge. There are about 100 toast strings left based on the number of search results, but it will probably be a few days before I get to them so I can open a new PR for those. |
Okay, I'll stop editing the strings here. There are still about 50 more toast messages remaining, but this PR just kept getting longer. More similar strings were combined. Most of the remaining strings are related to podcast episodes and are not all in toasts, so that will take a bit to go through the files and update everything. |
Thanks! I wanted to remove a lot of those success toasts because it is redundant when the change can be seen. |
Makes sense, thanks for cleaning those up. |
* Update: `pages/items/_id` toast messages * Update: account modal strings * Update: audio file data modal strings * Update: sleep timer set string * Update: loading indicator string * Update: lazy book card strings * Reorder keys * Fix: syntax error in LazyBookCard * Fix: json ordering * Fix: fix double message definition * Update: login form toast strings * Update: batch delete toast * Update: collection add toast messages * Replace: toasts in BookShelfToolbar * Update: playlist edit toasts * Update: Details tab * Add: title required string * Update: ereader toasts * Update: author toasts, title and name required toasts * Clean up "no updates" strings * Change: slug strings * Update: cover modal toasts * Change: cancel encode toasts * Change: failed to share toasts * Simplify: "renameFail" and "removeFail" toasts * Fix: ordering * Change: chapters remove toast * Update: notification strings * Revert: loading indicator (error in browser) * Update: collectionBooksTable toast * Update: "failed to get" strings * Update: backup strings * Update: custom provider strings * Update: sessions strings * Update: email strings * Update sort display translation strings, update podcast episode queue strings to use translation * Fix loading indicator please wait translation * Consolidate translations and reduce number of toasts --------- Co-authored-by: advplyr <advplyr@protonmail.com>
Fixes #3242
This PR updates the strings in the client mentioned in the above issue, as well as updating other strings in those files which were not translatable.
This PR does not update the task strings which are generated/updated by the server because right now only the client has i18n functionality. I opened #3303 to track this separately.