Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation strings added #3304

Merged
merged 38 commits into from
Aug 30, 2024
Merged

Conversation

nichwall
Copy link
Contributor

Fixes #3242

This PR updates the strings in the client mentioned in the above issue, as well as updating other strings in those files which were not translatable.

This PR does not update the task strings which are generated/updated by the server because right now only the client has i18n functionality. I opened #3303 to track this separately.

@nichwall
Copy link
Contributor Author

Got some more strings translated. I also cleaned up a few similar strings that were already in the translation files.

This PR should be good to merge. There are about 100 toast strings left based on the number of search results, but it will probably be a few days before I get to them so I can open a new PR for those.

@nichwall
Copy link
Contributor Author

Okay, I'll stop editing the strings here. There are still about 50 more toast messages remaining, but this PR just kept getting longer. More similar strings were combined.

Most of the remaining strings are related to podcast episodes and are not all in toasts, so that will take a bit to go through the files and update everything.

@advplyr
Copy link
Owner

advplyr commented Aug 30, 2024

Thanks! I wanted to remove a lot of those success toasts because it is redundant when the change can be seen.
Most of the "failed to get.." error toasts can be consolidated in the generic failed to load toast. There is always a more specific console log in the rare case it has to be distinguished.

@advplyr advplyr merged commit f0e70ed into advplyr:master Aug 30, 2024
6 checks passed
@nichwall
Copy link
Contributor Author

Makes sense, thanks for cleaning those up.

@nichwall nichwall deleted the machou_2_12_3_translations branch August 30, 2024 23:44
nichwall added a commit to nichwall/audiobookshelf that referenced this pull request Sep 13, 2024
* Update: `pages/items/_id` toast messages

* Update: account modal strings

* Update: audio file data modal strings

* Update: sleep timer set string

* Update: loading indicator string

* Update: lazy book card strings

* Reorder keys

* Fix: syntax error in LazyBookCard

* Fix: json ordering

* Fix: fix double message definition

* Update: login form toast strings

* Update: batch delete toast

* Update: collection add toast messages

* Replace: toasts in BookShelfToolbar

* Update: playlist edit toasts

* Update: Details tab

* Add: title required string

* Update: ereader toasts

* Update: author toasts, title and name required toasts

* Clean up "no updates" strings

* Change: slug strings

* Update: cover modal toasts

* Change: cancel encode toasts

* Change: failed to share toasts

* Simplify: "renameFail" and "removeFail" toasts

* Fix: ordering

* Change: chapters remove toast

* Update: notification strings

* Revert: loading indicator (error in browser)

* Update: collectionBooksTable toast

* Update: "failed to get" strings

* Update: backup strings

* Update: custom provider strings

* Update: sessions strings

* Update: email strings

* Update sort display translation strings, update podcast episode queue strings to use translation

* Fix loading indicator please wait translation

* Consolidate translations and reduce number of toasts

---------

Co-authored-by: advplyr <advplyr@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: missing translation 2.12.1+
2 participants