Fixed Day Calculation Logic for Stats Page #3777
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
The calculation of the days listened was based on the days with a displayed value. On a smaller scale, not all days of the last year were rendered. This PR changes the calculation of days to include those outside of the rendered days.
While I tried to incorporating the logic into the current loop, I failed because the day's position depends on "i," which would need to be expanded. Maybe I missed something, but the added burden of either going from back to front or adding logic that calculates the columns and rows based on the viewed days would significantly complicate the logic. Therefore some overhead is added by this PR
Which issue is fixed?
Discord
How have you tested this?
Mobile and Desktop, on a "Production" server