Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Day Calculation Logic for Stats Page #3777

Closed
wants to merge 2 commits into from

Conversation

Vito0912
Copy link
Contributor

@Vito0912 Vito0912 commented Jan 2, 2025

Brief summary

The calculation of the days listened was based on the days with a displayed value. On a smaller scale, not all days of the last year were rendered. This PR changes the calculation of days to include those outside of the rendered days.

While I tried to incorporating the logic into the current loop, I failed because the day's position depends on "i," which would need to be expanded. Maybe I missed something, but the added burden of either going from back to front or adding logic that calculates the columns and rows based on the viewed days would significantly complicate the logic. Therefore some overhead is added by this PR

Which issue is fixed?

Discord

How have you tested this?

Mobile and Desktop, on a "Production" server

@Vito0912
Copy link
Contributor Author

Vito0912 commented Jan 6, 2025

Fixed in a commit in main

@Vito0912 Vito0912 closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant