Enable subdirectory support by default #3810
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Switch to enabling subdirectory support with
/audiobookshelfon the server and web client, according to the plan laid out in discussion #3535.Which issue is fixed?
This finally fixes #385
Users will now be able to set their reverse proxies to proxy
/audiobookshelfsubdirectory requestsIn-depth Description
This is the last step in supporting subdirectory with the existing static site generation approach.
The plan is described in detail in #3535.
As a reminder, this will set a fixed subdirectory of
/audiobookshelfon the web client (non-subdirectory paths will get rewritten by the server), and the server will support both subdirectory requests (with/audiobookshelfprefix) and non-subdirectory requests (with no prefix).Note: Mobile app support for subdirectory is already implemented and checked in with audiobookshelf-app PR #1417, but is pending release of a new version. Other mobile clients that would like to support subdirectory access will likely need to make some changes in the spirit of that PR.
How have you tested this?
This PR just switches the feature on by default.
The many changes required to make this happen were previously tested in respective previous PRs, and were tested again to make sure they still worked now.
One thing I haven't tested properly is the reverse proxy part, since my reverse proxy (on my Synology NAS) doesn't support support subdirectory proxying. I am sure this works well once you set it up on a supporting reverse proxy (like NGINX), but haven't tested this myself.