fix warnings

CmisSync.Lib/Cmis/CmisUtils.cs

@@ -350,6 +350,7 @@ public static string GetProperty(IDocument document, string id)
         /// <returns></returns>
         public static string GetChangeLogToken(ISession session)
         {
+            //FIXME: should not clear cache!
             session.Clear(); // Clear all caches.
             session.Binding.GetRepositoryService().GetRepositoryInfos(null);
             string token = session.Binding.GetRepositoryService().GetRepositoryInfo(session.RepositoryInfo.Id, null).LatestChangeLogToken;

CmisSync.Lib/Config.cs

@@ -163,7 +163,7 @@ public Config(string fullPath)
             {
                 Load();
             }
-            catch (Exception e) {
+            catch (Exception) {
                 throw;
             }
         }
@@ -520,7 +520,7 @@ public override RemoteRepository Repository {
                     }
                 }
 
-                public virtual string Path {
+                public override string Path {
                     get {
                         return String.Empty;
                     }

CmisSync.Lib/ConfigMigration.cs

@@ -34,7 +34,7 @@ public static void Migrate()
             int configSchemaVersion = ConfigManager.CurrentConfig.ConfigSchemaVersion;
 
             // Skip migration if up-to-date.
-            if (configSchemaVersion == null || configSchemaVersion >= Config.SchemaVersion)
+            if (configSchemaVersion >= Config.SchemaVersion)
             {
                 return;
             }
@@ -167,7 +167,7 @@ private static bool IsAlfresco42OrLater(CmisSync.Lib.Config.SyncConfig.SyncFolde
 
                 return true;
             }
-            catch (Exception e)
+            catch (Exception)
             {
                 return false;
             }

CmisSync.Lib/Database/Database.cs

@@ -983,7 +983,6 @@ public void SetChangeLogToken(string token)
         }
 
         const string RemotePathPrefixKey = "RemotePathPrefix";
-        private Config.SyncConfig.SyncFolder repoinfo;
 
         /// <summary>
         /// Checks whether the database contains a given folders's id.

CmisSync.Lib/Sync/SyncFolderSyncronizer.cs

@@ -152,20 +152,11 @@ private void deleteLocalFiles()
             Dispose(false);
         }
 
-        /// <summary>
-        /// Implement IDisposable interface. 
-        /// </summary>
-        public void Dispose()
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
         /// <summary>
         /// Dispose pattern implementation.
         /// </summary>
-        protected void Dispose(bool disposing)
-        {
+        protected override void Dispose(bool disposing)
+        {            
             if (!this.disposed)
             {
                 if (disposing)
@@ -174,6 +165,7 @@ protected void Dispose(bool disposing)
                 }
                 this.disposed = true;
             }
+            base.Dispose(disposing);
         }
 
         /// <summary>
@@ -312,7 +304,7 @@ private IFolder tryGetObjectByPath(string remoteFolderPath, int tries)
                 {
                     return (IFolder)getSession().GetObjectByPath(remoteFolderPath);
                 }
-                catch (CmisBaseException e)
+                catch (CmisBaseException)
                 {
                     //maybe a temporary error, retry
                     tries--;

CmisSync.Lib/Sync/SyncFolderSyncronizerBase.cs

@@ -279,7 +279,7 @@ public void Dispose()
         /// <summary>
         /// Dispose pattern implementation.
         /// </summary>
-        protected void Dispose(bool disposing)
+        protected virtual void Dispose(bool disposing)
         {
             if (!this.disposed)
             {

CmisSync.Lib/XmlUri.cs

@@ -66,7 +66,7 @@ public void WriteXml(XmlWriter writer)
         /// <summary>
         /// String representation of the URI.
         /// </summary>
-        public string ToString()
+        public override string ToString()
         {
             return _value.ToString();
         }

CmisSync/CmisSync.csproj

@@ -14,6 +14,7 @@
     <ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
     <WarningLevel>4</WarningLevel>
     <NuGetPackageImportStamp>79528698</NuGetPackageImportStamp>
+    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <PlatformTarget>AnyCPU</PlatformTarget>
@@ -77,6 +78,9 @@
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
     <Prefer32Bit>true</Prefer32Bit>
   </PropertyGroup>
+  <PropertyGroup>
+    <ApplicationIcon>Resources\cmissync-app.ico</ApplicationIcon>
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="AvalonWizard, Version=1.2.0.0, Culture=neutral, processorArchitecture=MSIL">
       <HintPath>..\packages\AvalonWizard.1.2.0\lib\net40\AvalonWizard.dll</HintPath>

CmisSync/ViewModels/AccountViewModel.cs

@@ -126,7 +126,7 @@ private void save(Window window)
                 }
                 ConfigManager.CurrentConfig.Save();
                 window.Close();
-            }catch(Exception e){
+            }catch(Exception){
                 MessageBox.Show("Unable to obtain the corrct url or wrong credentials.", "Error");
             }
         }