-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implementing DBSCAN #2477
Comments
@aeon-actions-bot assign @aryanpola |
DBSCAN is already implemented in sklearn, and aeon depends on sklearn. Why do we need to re-implement it directly in aeon? |
The clustering examples had a graph contained all the clustering sub-modules which includes density based, so figured why not implement it in aeon. |
Agreed that unless there is some reason the sklearn version wont work (or is insufficient in any other way) that theres no need to have it here really. Any thoughts @chrisholder ? |
the problem with dbscan is that it does not have a predict, i.e. it can only cluster train data. I'm not sure of the best way to deal with this. I'll have a go with the scikit learn version |
Yep, not having a predict function makes it a lot more difficult to cluster the newer points into the existing clusters (requires reevaluation of the model). |
Describe the feature or idea you want to propose
We currently do not have a sub-module for density-based clustering. This issue is for implementing Density-Based Spatial Clustering of Applications with Noise (DBSCAN).
Describe your proposed solution
Scikit-learn for reference: https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/cluster/_dbscan.py
Describe alternatives you've considered, if relevant
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: