-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Added search functionality for estimator overview table #2496
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
I can confirm, the RDT-build does not produce the expected results. |
@baraline @SebastianSchmidl |
Great job, search is working great ! Only thing left to correct would be to adapt the table style to the dark/light mode toggle, currently, it displays only as light theme even with dark mode on. For pre-commit, I would suggest you install it locally using the dev documentation, it will be way easier to see and fix the issues this way. It can even fix some issues automatically when you try to commit (you need to re-add and commit if some fixes have been auto applied), it will also tell you errors and what to do to fix them |
Thank you for the feedback! I will look into adapting the table style to the dark/light mode toggle so that it displays correctly in both themes as well as try pre commit. |
For me, the dark/light mode works as expected:
The search is also really nice 👍🏼 🥳 I have some additional requests (unrelated to the search):
This does not need to be fixed in this PR. But, do you have any idea how to deal with it? |
Reference Issues/PRs
Fixes #1438
What does this implement/fix? Explain your changes.
Added search functionality and page sorting for estimator overview table
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
@all-contributors please add @kavya-r30 for code
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access