-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update Partitional clustering notebook #2483
base: main
Are you sure you want to change the base?
[DOC] Update Partitional clustering notebook #2483
Conversation
I have addressed issue aeon-toolkit#1805 by updating the partitional_clustering notebook to include all the supported distance metrics.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
Hi @MatthewMiddlehurst @TonyBagnall, Thanks in advance for your feedback! |
View / edit / reply to this conversation on ReviewNB TonyBagnall commented on 2025-01-14T08:56:08Z not sure if it is just reviewnb, but Squared and ADTW seem to be on the same line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, could you just check the line break for ADTW?
Hi @TonyBagnall , I’ve double-checked the code and JSON structure, and everything seems fine. Here’s the relevant snippet for reference: "<ul>\n",
" <li>K-means, K-medoids supported distances:\n",
" <ul>\n",
" <li>Euclidean - parameter string 'euclidean'</li>\n",
" <li>Manhattan - parameter string 'manhattan'</li>\n",
" <li>Minkowski - parameter string 'minkowski'</li>\n",
" <li>Soft DTW - parameter string 'soft_dtw'</li>\n",
" <li>Shift Scale - parameter string 'shift_scale'</li>\n",
" <li>Squared - parameter string 'squared'</li>\n",
" <li>ADTW - parameter string 'adtw'</li>\n",
" <li>DTW - parameter string 'dtw'</li>\n",
" <li>DDTW - parameter string 'ddtw'</li>\n",
" <li>WDTW - parameter string 'wdtw'</li>\n",
" <li>WDDTW - parameter string 'wddtw'</li>\n",
" <li>LCSS - parameter string 'lcss'</li>\n",
" <li>ERP - parameter string 'erp'</li>\n",
" <li>EDR - parameter string 'edr'</li>\n",
" <li>MSM - parameter string 'msm'</li>\n",
" <li>TWE - parameter string 'twe'</li>\n",
" <li>SBD - parameter string 'sbd'</li>\n",
" </ul>\n",
" </li>\n",
"</ul>\n" The line break for ADTW looks correct here, but I noticed that in ReviewNB, there are formatting issues where some items appear on the same line as others. I’m not sure why this discrepancy is happening, as the code itself appears fine. Please let me know if you think there’s another aspect I should check! |
I have addressed issue #1805 by updating the partitional_clustering notebook to include all the supported distance metrics.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access