Make all jobs source config.resources. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
reviewed
Aug 1, 2024
aerorahul
approved these changes
Aug 1, 2024
WalterKolczynski-NOAA
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the two remaining
GEMPAKJ-Jobs that were not sourcingconfig.resourcesdo so. Additionally, it adds a config file for thefbwindJ-Job and adds definitions for the job toconfig.resourcesbased on theecfdefinitions for the job.I made these changes locally to the CI clone for PR 2753 on WCOSS2 and relaunched the previously failed GEMPAK jobs, which are now running successfully. I will open this for review when the WCOSS2 extended test is finished.