-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVOPS-198] Run cleanup script on Mac M1 runners when job starts #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #657 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 100 100
Lines 15341 15341
=======================================
Hits 12477 12477
Misses 2864 2864 ☔ View full report in Codecov by Sentry. |
juliannguyen4
force-pushed
the
DEVOPS-198-mac-m1-cleanup
branch
from
August 16, 2024 22:16
2071e5e
to
212b1e9
Compare
This reverts commit 51e4199.
Fix use native 3.8 install
justinlee-aerospike
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes:
Build the Mac arm64 wheels using the Github runners instead of the self-hosted Mac M1 runners
Workflow testing:
The latest run (custom server tag) should successfully cleanup the Mac M1 runner:
Minor bug I fixed after running these tests but I didn't bother testing it: b9287e3