Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3117] Replace an existing node in the cluster when a new peer has the same node name, but a different IP address #673

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 16, 2024

Massif, build artifacts, valgrind looks fine

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (25ac489) to head (52a2f32).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #673   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         100      100           
  Lines       15132    15132           
=======================================
  Hits        12252    12252           
  Misses       2880     2880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review September 17, 2024 16:00
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good

@juliannguyen4 juliannguyen4 merged commit d200c6d into dev Sep 17, 2024
142 of 149 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3117-replace-node-same-name branch September 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants