Changeable cutoff for number of genes found in DB for module2df #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I added the possibility that users can freely choose the cutoff for
module2df
in thectx
step of pySCENIC.I had the issue that this error was triggered for a majority of the identified modules (as others also reported).
All I did was adding a CLI argument and implemented the manual cutoff in the
module2df
function, as well as all other functions that rely onmodule2df
. I hope I found all of them.According to my testing, the default settings work as previously, but now the user is able to lower the cutoff to whatever percentage he/she wants. I think this makes pySCENIC more flexible. If you think there should be a minimum cutoff, let me know. I think you had a good reason to set it to 80%.
I'd also want to add: Thank you for this great tool and the nice python implementation of it 😄
All the best,
Kevin
pytest
output: