Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(compiler): explain compilerPath argument and related fixes #1870

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

davidyuk
Copy link
Member

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk requested a review from marc0olo July 28, 2023 10:13
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c84671) 81.37% compared to head (d81129e) 81.37%.
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1870   +/-   ##
========================================
  Coverage    81.37%   81.37%           
========================================
  Files           94       94           
  Lines         3361     3361           
  Branches       671      671           
========================================
  Hits          2735     2735           
  Misses         303      303           
  Partials       323      323           
Files Changed Coverage Δ
src/Middleware.ts 67.64% <ø> (ø)
src/Node.ts 91.66% <ø> (ø)
src/aepp-wallet-communication/rpc/types.ts 100.00% <ø> (ø)
src/aepp-wallet-communication/wallet-detector.ts 26.31% <0.00%> (ø)
src/contract/compiler/Cli.ts 83.78% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

*/
export default class CompilerCli extends CompilerBase {
#path: string;

#ensureCompatibleVersion = Promise.resolve();

/**
* @param compilerPath - A path to aesophia_cli binary, by default uses the integrated one
Copy link
Contributor

@marc0olo marc0olo Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"integrated one" means that the CLI is actually shipped along with the SDK. do I understand correctly? I think it should be made clear to the reader that this is actually the case. I didn't know that 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that windows is not supported here using the CLI compiler, right? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I understand correctly?

Yep.

I've checked it before, it should be working in windows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's cool. wouldn't have expected the CLI binary of the compiler to work with windows

Copy link
Member Author

@davidyuk davidyuk Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is an Erlang VM binary as I understand

@marc0olo
Copy link
Contributor

it would also be great to have this explained in the contract guide here:

few things I would love to see added/adjusted:

  1. explain the difference between CLI compiler and http compiler
    • also, provide a note that the "hosted" compiler will be decommissioned and tell the user to run their own local http compiler if needed or to install the erlang dependency to use the shipped CLI
    • also provide a note that windows doesn't support the CLI compiler (if that's the case)
  2. show usage of compiler methods directly that show how to:
    • generate & use bytecode & ACI (seems currently missing)
  3. refer to or explain the utility method to get the filesystem map

@davidyuk davidyuk force-pushed the feature/docs-comp-cli branch 4 times, most recently from ee87ca9 to b76d17c Compare September 10, 2023 11:32
@davidyuk davidyuk changed the title docs(compiler): explain compilerPath argument docs(compiler): explain compilerPath argument and related fixes Sep 10, 2023
@davidyuk davidyuk added this to the v13.2.2 milestone Sep 10, 2023
@davidyuk davidyuk merged commit 27f3530 into develop Sep 19, 2023
4 of 5 checks passed
@davidyuk davidyuk deleted the feature/docs-comp-cli branch September 19, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants