-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(compiler): explain compilerPath
argument and related fixes
#1870
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1870 +/- ##
========================================
Coverage 81.37% 81.37%
========================================
Files 94 94
Lines 3361 3361
Branches 671 671
========================================
Hits 2735 2735
Misses 303 303
Partials 323 323
☔ View full report in Codecov by Sentry. |
*/ | ||
export default class CompilerCli extends CompilerBase { | ||
#path: string; | ||
|
||
#ensureCompatibleVersion = Promise.resolve(); | ||
|
||
/** | ||
* @param compilerPath - A path to aesophia_cli binary, by default uses the integrated one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"integrated one" means that the CLI is actually shipped along with the SDK. do I understand correctly? I think it should be made clear to the reader that this is actually the case. I didn't know that 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that windows is not supported here using the CLI compiler, right? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I understand correctly?
Yep.
I've checked it before, it should be working in windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's cool. wouldn't have expected the CLI binary of the compiler to work with windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is an Erlang VM binary as I understand
it would also be great to have this explained in the contract guide here: few things I would love to see added/adjusted:
|
ee87ca9
to
b76d17c
Compare
b76d17c
to
d81129e
Compare
compilerPath
argumentcompilerPath
argument and related fixes
This PR is supported by the Æternity Crypto Foundation