Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aepp): use complete type of WalletInfo object #1880

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

davidyuk
Copy link
Member

replaces #1879

This PR is supported by the Æternity Crypto Foundation

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 97.72% and project coverage change: +0.04% 🎉

Comparison is base (30fad96) 81.36% compared to head (eeba565) 81.40%.
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1880      +/-   ##
===========================================
+ Coverage    81.36%   81.40%   +0.04%     
===========================================
  Files           94       94              
  Lines         3380     3361      -19     
  Branches       681      671      -10     
===========================================
- Hits          2750     2736      -14     
+ Misses         302      300       -2     
+ Partials       328      325       -3     
Files Changed Coverage Δ
src/aepp-wallet-communication/rpc/types.ts 100.00% <ø> (ø)
src/aepp-wallet-communication/wallet-detector.ts 26.31% <0.00%> (ø)
src/AeSdkWallet.ts 77.86% <100.00%> (+0.94%) ⬆️
src/chain.ts 87.05% <100.00%> (ø)
src/contract/Contract.ts 75.28% <100.00%> (+0.13%) ⬆️
src/spend.ts 100.00% <100.00%> (ø)
src/tx/builder/field-types/index.ts 100.00% <100.00%> (ø)
src/tx/builder/field-types/u-int.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk merged commit b1f4883 into develop Aug 24, 2023
8 checks passed
@davidyuk davidyuk deleted the feature/fix-wallet-detector-type branch August 24, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant