Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy 0.12 #276

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Bevy 0.12 #276

merged 6 commits into from
Nov 10, 2023

Conversation

TristanCacqueray
Copy link
Contributor

No description provided.

@TristanCacqueray
Update bevy_picking_ui for v0.12
f71a0f2 
This change replaced the now removed ComputedVisibility with the
ViewVisibility component
@TristanCacqueray TristanCacqueray marked this pull request as draft November 4, 2023 15:50
@TristanCacqueray
Copy link
Contributor Author

TristanCacqueray commented Nov 4, 2023 •
edited
Loading

This is blocked by aevyrie/bevy_eventlistener#11 and aevyrie/bevy_mod_raycast#100 and dimforge/bevy_rapier#439

@TristanCacqueray TristanCacqueray mentioned this pull request Nov 4, 2023
Closed
@TristanCacqueray TristanCacqueray marked this pull request as ready for review November 6, 2023 02:29
@nametable
Copy link
Contributor

Found a few problems with the bevy_sprite_picking backend in 0.12. Basically ComputedVisibility -> ViewVisibility and size() now returns a UVec2 instead of a Vec2, after fixing those, the sprite backend works for me in 0.12. Here's the changes I made to the backend (@TristanCacqueray I can PR to you or you can just snag the simple changes): nametable@834d6f2

@nametable @TristanCacqueray
Update bevy_picking_sprite backend for bevy 0.12 - to use ViewVisibil…
a152595 
…ity instead of ComputedVisibility - cast UVec2 to Vec2 since size() now returns UVec2
@TristanCacqueray
Copy link
Contributor Author

Thanks @nametable, to be honest, I am only using the backend for ui-navigation.

@thombruce thombruce mentioned this pull request Nov 8, 2023
Merged
5 tasks
@tungtose
Copy link

tungtose commented Nov 9, 2023

Tested with bevy_sprite_picking backend

This was referenced Nov 10, 2023
Closed
Closed
@aevyrie
Copy link
Owner

aevyrie commented Nov 10, 2023

Thanks for the contribution!

@aevyrie aevyrie merged commit 0ca48f7 into aevyrie:main Nov 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TristanCacqueray @nametable @tungtose @aevyrie