Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI to release wf #30

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add PyPI to release wf #30

merged 1 commit into from
Aug 31, 2023

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Aug 30, 2023

Proposed changes
Minor update to the release workflow, such that a PyPI deployment occurs anytime a new tagged version is released. A repository specific API token has been generated for this purpose. Also updates to use a tagged version of the workflows rather than point to main

Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Aug 30, 2023
@kaitj kaitj changed the title add pypi deploy action to release wf Add PyPI to release wf Aug 30, 2023
@github-actions github-actions bot requested a review from tkkuehn August 30, 2023 19:55
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #30 (80e5c81) into main (599eac7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          378       378           
=========================================
  Hits           378       378           
Components Coverage Δ
afids_utils/afids.py ∅ <ø> (∅)
afids_utils/ext 100.00% <ø> (ø)
afids_utils/transforms.py 100.00% <ø> (ø)

@kaitj kaitj linked an issue Aug 30, 2023 that may be closed by this pull request
@kaitj kaitj merged commit ac74285 into afids:main Aug 31, 2023
8 checks passed
@kaitj kaitj deleted the maint/gh-pypi-wf branch August 31, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Add poetry publish step to GHA release workflow
2 participants