Add methods for handling JSON #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 8 9 +1
Lines 530 656 +126
==========================================
+ Hits 530 656 +126
|
tkkuehn
reviewed
Sep 15, 2023
| ) -> tuple[str, str]: | ||
| """Internal function to extract metadata from json files | ||
|
|
||
| Note: Slicer version is not currently included in the json file |
There was a problem hiding this comment.
Note: This is perhaps another argument for dropping slicer_version from AfidSet
There was a problem hiding this comment.
Yes, I agree - if we end up dropping this, I would prefer to do it in a separate PR
tkkuehn
requested changes
Sep 15, 2023
Currently returning the slicer_version as "unknown" as the version is not currently specified in the .json file outputted from the slicer markup json.
tkkuehn
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #17 by adding in the necessary methods and tests for handling JSON associated fiducials. Also took the opportunity to update some existing docstrings and names of fcsv associated tests.
NOTE: This one should be reviewed and merged after #37, as it has been rebased to account for the coordinate system conventions
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe qualitytaskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.