-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional strategy and helpers.py #34
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 10 +1
Lines 656 665 +9
=========================================
+ Hits 656 665 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, one of which doesn't need to be addressed here necessarily.
This also needs a merge from main
e82d752
to
c8ada4d
Compare
- update AfidPosition dunder to perform subtraction along spatial dimensions - add compute_AFLE method to compute and return errors along each spatial dimension, as well as afle
- Reduce the number of lines in each test by setting hypothesis settings by defining callable functions in helpers.py - Simplify generation of valid characters by adding strategy for generating valid characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Side note: We should add pyright to this project given that a lot of the typing is there already
Yes, I agree. I'll throw that into a separate PR. |
Proposed changes
Tried to reduce the rewriting of common settings and generation of valid characters. To that end:
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe quality
taskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.