Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR reviewer list #40

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Update PR reviewer list #40

merged 2 commits into from
Oct 6, 2023

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Sep 20, 2023

Proposed changes
Minor change to update the PR reviewer list. Wanted to get this in before I forgot.

Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added maintenance Updates or improvements that do not change functionality of the code skip_changelog skip_changelog Changes to the repository that should not be documented in the CHANGELOG and removed maintenance Updates or improvements that do not change functionality of the code labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #40 (47faa70) into main (48768c8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          654       654           
=========================================
  Hits           654       654           
Components Coverage Δ
afids_utils/afids.py ∅ <ø> (∅)
afids_utils/ext 100.00% <ø> (ø)
afids_utils/transforms.py 100.00% <ø> (ø)

@kaitj kaitj force-pushed the update-reviewers branch 2 times, most recently from 74e2a63 to 1e3e2ae Compare October 3, 2023 13:19
Copy link
Contributor

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@kaitj kaitj marked this pull request as ready for review October 6, 2023 14:58
@github-actions github-actions bot requested a review from tkkuehn October 6, 2023 15:00
@kaitj kaitj merged commit 6a3a168 into main Oct 6, 2023
45 checks passed
@kaitj kaitj deleted the update-reviewers branch October 6, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_changelog skip_changelog Changes to the repository that should not be documented in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants