Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git release dependency for pypi release #53

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Dec 12, 2023

Proposed changes
The PyPI release action currently runs in parallel with the Github release. This can cause the previous tag to be (incorrectly) used, causing a conflict with trying to push a new release to PyPI. This adds a dependency of the PyPI portion of the workflow to depend on the github release to be first performed.

Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the bug Something isn't working label Dec 12, 2023
@kaitj kaitj self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #53 (3412ed9) into main (801f263) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          965       965           
=========================================
  Hits           965       965           
Components Coverage Δ
afids_utils/afids.py 100.00% <ø> (ø)
afids_utils/ext 100.00% <ø> (ø)
afids_utils/metrics.py 100.00% <ø> (ø)
afids_utils/plotting.py 100.00% <ø> (ø)
afids_utils/transforms.py 100.00% <ø> (ø)

@kaitj kaitj merged commit 3a9cce5 into afids:main Dec 12, 2023
25 checks passed
@kaitj kaitj deleted the bug/release-pypi branch December 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant