Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow same MAC addresses in different networks #92

Open
sebschrader opened this issue May 12, 2020 · 2 comments
Open

Allow same MAC addresses in different networks #92

sebschrader opened this issue May 12, 2020 · 2 comments
Assignees
Milestone

Comments

@sebschrader
Copy link
Member

Currently duplicate MAC addresses for dhcphost are rejected:

CREATE MATERIALIZED VIEW dhcphost AS

It seems, that dnsmasq is fine with duplicate MAC addresses, as long as they are in different subnets:

https://github.com/dnsmasq/dnsmasq/blob/ce5732e84fc46d7f99c152f736cfb4ef5ec98a01/src/dhcp-common.c#L292

If that's the case, we should allow that, because duplicate MAC addresses can happen, if users move.

@sebschrader sebschrader added this to the 0.5 milestone May 12, 2020
@sebschrader sebschrader self-assigned this Nov 2, 2020
@sebschrader
Copy link
Member Author

Fixed in 2ec2219

@lukasjuhrich
Copy link
Collaborator

Not quite fixed:

--
-- Name: auth_dhcp_host_MAC_idx; Type: INDEX; Schema: public; Owner: {{ constants.DATABASE_USER }}
--
CREATE UNIQUE INDEX "auth_dhcp_host_MAC_idx" ON auth_dhcp_host USING btree ("MAC");

This index still prevents multiple MAC addresses.

@lukasjuhrich lukasjuhrich reopened this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants