extract can_target to .permissions module

pycroft/lib/user/__init__.py

@@ -2,7 +2,6 @@
     setup_ipv4_networking,
     store_user_sheet,
     get_user_sheet,
-    can_target,
     create_user,
     login_available,
     move_in,
@@ -76,6 +75,7 @@
 from .mail_confirmation import (
     confirm_mail_address,
 )
+from .permission import can_target
 
 from .exc import (
     HostAliasExists,

pycroft/lib/user/_old.py

@@ -135,12 +135,6 @@ def get_user_sheet(sheet_id: int) -> bytes | None:
     return storage.data
 
 
-def can_target(user: User, processor: User) -> bool:
-    if user != processor:
-        return user.permission_level < processor.permission_level
-    else:
-        return True
-
 def create_user(
     name: str, login: str, email: str, birthdate: date,
     groups: t.Iterable[PropertyGroup], processor: User | None, address: Address,

pycroft/lib/user/edit.py

@@ -7,7 +7,8 @@
 from pycroft.model.session import with_transaction
 from pycroft.model.user import User
 
-from ._old import can_target, send_confirmation_email
+from ._old import send_confirmation_email
+from .permission import can_target
 
 
 @with_transaction

pycroft/lib/user/passwords.py

@@ -4,8 +4,7 @@
 from pycroft.model.session import with_transaction
 from pycroft.model.user import User
 
-from ._old import can_target
-
+from .permission import can_target
 
 def maybe_setup_wifi(user: User, processor: User) -> str | None:
     """If wifi is available, sets a wifi password."""

pycroft/lib/user/permission.py

@@ -0,0 +1,8 @@
+from pycroft.model.user import User
+
+
+def can_target(user: User, processor: User) -> bool:
+    if user != processor:
+        return user.permission_level < processor.permission_level
+    else:
+        return True