Pydantic models for table json responses #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caught by introduction of pydantic model
|
note to self: perhaps I should restrict myself to tables; for simple json responses it may be overkill and redundant to add a pydantic model. tables are complex enough so that pydantic models pose an advantage. |
lukasjuhrich
force-pushed
the
pydantic
branch
2 times, most recently
from
1775aa2
to
7e0408e
Compare
…except for the splitted table, which is a little more complicated because it basically has two schemas at once (splitted and unsplitted).
The rest is just darker reformatting.
lukasjuhrich
commented
Aug 1, 2023
the latter has been deprecated in pydantic v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to replace the dicts returned in the table JSON endpoints by pydantic models.
After having done this, frontend tests can utilize these models to validate responses and do easier introspection.
possible next issue:
/apiendpoints