Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve view functions in facilities blueprint #658

Merged
merged 22 commits into from
Aug 16, 2023
Merged

Improve view functions in facilities blueprint #658

merged 22 commits into from
Aug 16, 2023

Conversation

lukasjuhrich
Copy link
Collaborator

@lukasjuhrich lukasjuhrich commented Aug 11, 2023 •
edited
Loading

  • Upgrades to flask~=2.3 (and werkzeug>=2.0)
  • Improves the handle_errors context manager for more ergonomic usage (the try can be omitted, session.begin_nested needs to be called explicitly
  • enforces stricter typing rules for the facilities blueprint
  • Adds type hints to flask view functions across the board. This prevents stpuid bugs like forgetting to call .model_dump on a pydantic model.
  • Enforces the latter via a semgrep rule.

lukasjuhrich
lukasjuhrich commented Aug 11, 2023
View reviewed changes
web/app.py Outdated Show resolved Hide resolved
@lukasjuhrich lukasjuhrich force-pushed the facilities_improvements branch 2 times, most recently from 8e63e4e to c5f02d0 Compare August 11, 2023 18:04
@lukasjuhrich lukasjuhrich mentioned this pull request Aug 11, 2023
Merged
@lukasjuhrich lukasjuhrich marked this pull request as draft August 11, 2023 18:05
@lukasjuhrich lukasjuhrich changed the base branch from develop to flask_23 August 11, 2023 18:06
@lukasjuhrich lukasjuhrich force-pushed the flask_23 branch 2 times, most recently from 210c90c to 534c0b8 Compare August 14, 2023 16:32
@lukasjuhrich lukasjuhrich force-pushed the facilities_improvements branch 2 times, most recently from f13afde to 614369f Compare August 14, 2023 16:55
@lukasjuhrich lukasjuhrich changed the base branch from flask_23 to develop August 14, 2023 16:55
@lukasjuhrich
[web] restructure room creation and implement custom error handling
f5f7b18 
The custom error handling allows us to be potentially more specific
than just issuing a flash message.
@lukasjuhrich
[web] improve determine_building_or_404 usage and logic
225babd
@lukasjuhrich
[web] extract address fields default filling to CreateAddressForm
ac0c069
@lukasjuhrich
[web] restructure facilities.room_edit
bcc74ac
@lukasjuhrich
[ci] check for blueprint return type hint with semgrep rule
4be5d6b
@lukasjuhrich
[web] type hint blueprint.facilities endpoints
dff7042
@lukasjuhrich
[ci] remove temporary semgrep rule
21371d2 
obsolete, because `handle_errors` does not take a session anymore.
@lukasjuhrich
[web] restructure facilities.patch_port_create
90a032b
@lukasjuhrich
[web] restructure facilities.patch_port_edit
4991e15
@lukasjuhrich
[web] restructure facilities.patch_port_delete
f2ad08b
@lukasjuhrich
[web] add type hints to app and finance blueprint
fc98441
@lukasjuhrich
[web] add type hints for user blueprint
f0c16da
@lukasjuhrich
[web] add type hints to host and infrastructure blueprints
d6f2712
@lukasjuhrich
[web] add type hints for remaining view functions
90de086
@lukasjuhrich
[web] enable mypy checking on facilities blueprint
b966df4 
Plus, fix all the admonitions.
@lukasjuhrich
[web] enforce stricter typing rules for blueprints.facilities
ae781a0
@lukasjuhrich
[web] fix residual mypy errors
dba5d21 
`BaseResponse` has ben merged with `Response`, see
pallets/werkzeug#1963.
@lukasjuhrich
[ci] pin mypy to ~1.5.0 and fix unused suppression
12b87bb 
Now, after v1, compat release pinning makes sense.
@lukasjuhrich
[web] properly type sentry debug endpoint
b421077
@lukasjuhrich
[web] rename handle_errors → abort_on_error
af4da9e 
Also, remove the keyword argument in some invocations; it has been
introduced before when the first argument was `session`.  This is now
more noise than it is helpful.
@lukasjuhrich lukasjuhrich marked this pull request as ready for review August 16, 2023 10:58
@lukasjuhrich lukasjuhrich merged commit 9cdffb0 into develop Aug 16, 2023
7 checks passed
@lukasjuhrich lukasjuhrich deleted the facilities_improvements branch September 6, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasjuhrich