Update to Flask 2.3 #659
Merged
Update to Flask 2.3 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Werkzeug 2.3, the LocalProxy implementation has been reworked slightly; `_get_current_object` is now closure directly binding the `local`, so setting the attribute does not do anything.
Since we call `.remove()`, we actually expect a `scoped_session` rather than just a `Session`. Furthermore, we make use of the newer generic typing features of said types.
This is necessary so that `load_default` works. That's what triggered that annoying deprecation warning about `metadata`. See https://marshmallow.readthedocs.io/en/latest/changelog.html#id11
This is reported: https://foss.heptapod.net/python-libs/passlib/-/issues/185 Given that passlib 1.8 will be dropping old versions[1], the maintainer will most likely fix this in 1.8. [1] https://foss.heptapod.net/python-libs/passlib/-/issues/119
This appearently is not necessary anymore.
the second attribute to `LocalProxy` now serves as an attribute name to be looked up.
The `type: ignore` is probably obsolete due to the sentry-sdk update, and the url_for false positive seems like a mypy quirk.
This contains the fix for sqlalchemyorg/sphinx-paramlinks#20, which adresses some deprecation warnings.
in 2.1, calling `.json` on a request without the proper media type aborts with 415 WRONG MEDIA TYPE. `is_json` is what we want here.
Since v0.251, ruff supports `match` statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker for #658