Fully enable mypy for web package
#661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a type admonition, because we set a value to a `dict` instead of an `OrderedDict`
This causes the type hint to be more correct; since `ABC` does not support abstract class attributes, we implement the check ourselves using the `__init_subclass__` hook.
This includes - using 2.0-style select instead of `Query` - using explicit `bool` conversion for functions returning `bool` (short circuiting can cause either element of a boolean clause to be returned as-is) - some type hints are added / weakened / strengthened / fixed appropriately
This is cleaner than just dynamically setting attributes on `Subnet`.
lukasjuhrich
commented
Aug 17, 2023
| @@ -56,6 +52,7 @@ module = [ | |||
| "web.blueprints", | |||
| "web.blueprints.access", | |||
| "web.blueprints.facilities", | |||
| # "web.blueprints.host", | |||
There was a problem hiding this comment.
That should be reverted, but I am lazy and we want to look at enabling stricter rules for most modules, anyway
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #559