Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up pycroft.lib.user into separate packages #746

Merged
merged 34 commits into from
Sep 28, 2024
Merged

Split up pycroft.lib.user into separate packages #746

merged 34 commits into from
Sep 28, 2024

Conversation

lukasjuhrich
Copy link
Collaborator

@lukasjuhrich lukasjuhrich commented Sep 9, 2024 •
edited
Loading

This

  • splits up lib.user into manageable components
  • turns on strict nullability for lib.user
  • In the process, moves the mail configuration into a contextvar lib.mail.config.

@lukasjuhrich lukasjuhrich force-pushed the lib_user_explode branch 8 times, most recently from 88354de to 49912c1 Compare September 20, 2024 12:37
@lukasjuhrich
extract lib.user.passwords
7a7315a
@lukasjuhrich
extract lib.user.mail
d765be1
@lukasjuhrich
extract can_target to .permissions module
8eb0331
@lukasjuhrich
Extract lib.user.user_sheet
3b8fda3
@lukasjuhrich
Move user identification heuristics to lib.user.member_request
4dec3db
@lukasjuhrich
Extract lib.user.info
d61e72c 
This also removes the unused `has_positive_balance` function (unused
as a template filter)
@lukasjuhrich
Migrate lib.user.migrate_user_host to lib.host.migrate_host
d28c991
@lukasjuhrich
Explicitly pass session.session in migrate_host
5e4c796
@lukasjuhrich
Migrate lib.user.setup_ipv4_networking to lib.host
e7a84c3
@lukasjuhrich
Move membership_{begin,end}_date to lib.user.info
96a7d4c
@lukasjuhrich
Improve naming of membership_*_date functions
6cac442
@lukasjuhrich
Make scheduled_membership_* implementations more concise
104219c
@lukasjuhrich
extract lib.user.lifecycle
1977309
@lukasjuhrich
Stricter typing for lib.user
a4a9060
@lukasjuhrich
typing: Strict nullability for lib.user.mail_confirmation
bbd4ae0
@lukasjuhrich lukasjuhrich marked this pull request as ready for review September 20, 2024 16:06
@lukasjuhrich lukasjuhrich merged commit b3cbc59 into develop Sep 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Software Dev Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasjuhrich