Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fints login #755

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Fix fints login #755

merged 7 commits into from
Sep 30, 2024

Conversation

FestplattenSchnitzel
Copy link
Member

@FestplattenSchnitzel FestplattenSchnitzel commented Sep 27, 2024 •
edited
Loading

Closes #756

  • Move stuff to pycroft/lib where it makes sense
  • Refactor

@FestplattenSchnitzel FestplattenSchnitzel force-pushed the fix_fints_login branch 2 times, most recently from 815fda7 to a1f5a45 Compare September 27, 2024 13:05
@FestplattenSchnitzel FestplattenSchnitzel mentioned this pull request Sep 27, 2024
Closed
@lukasjuhrich
Copy link
Collaborator

I would actually not polish this too much. If it works, it works. Leaving some small comments.

lukasjuhrich
lukasjuhrich reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@lukasjuhrich lukasjuhrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You don't really need to push down anything in the lib, the most important part (extracting the client creation) has already been done. good job.

web/blueprints/finance/__init__.py Outdated Show resolved Hide resolved
web/blueprints/finance/__init__.py Outdated Show resolved Hide resolved
web/blueprints/finance/__init__.py Outdated Show resolved Hide resolved
web/templates/finance/fints_login.html Outdated Show resolved Hide resolved
web/blueprints/finance/__init__.py Outdated Show resolved Hide resolved
tests/external_services/test_fints.py Outdated Show resolved Hide resolved
web/blueprints/finance/__init__.py Outdated Show resolved Hide resolved
@FestplattenSchnitzel FestplattenSchnitzel marked this pull request as ready for review September 30, 2024 15:34
@FestplattenSchnitzel FestplattenSchnitzel merged commit a6c0665 into develop Sep 30, 2024
5 of 7 checks passed
@FestplattenSchnitzel FestplattenSchnitzel deleted the fix_fints_login branch September 30, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasjuhrich lukasjuhrich lukasjuhrich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FinTS login
2 participants
@FestplattenSchnitzel @lukasjuhrich