Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide better shims updates and type/build checks using TS.
It organizes shims into a
shims
directory. Inside of said directory there's aglobals
directory. There's where all JS global shims live as separate TS files.Pros
Pain points
This is def better than the mega string manipulation we had before, but it's still far from ideal:
Because of how the bundler processes globals + how we inject code into the engine wrap + the need to shim
require
for the JS engine (instead of shimming just modules):require
global. See howaxios
,fs
, etc. are done.global -> shim variable name
. Seeshims/globals/index.ts